config: turning down v1 config #4678
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
@envoyproxy/maintainers anyone have any final objections? Once I think we're good to merge I'll send an email to envoy-announce and ship it. |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
There was a problem hiding this comment.
Yup, IMO this is the way to start. Obviously, unwinding v1 will also involve turning off v1 discovery fetches which can still happen via the v2 config, but I agree let's see how much complaining we get when this lands. We might even want this to be the only thing we do between now and 1.9.0 snap.
source/server/options_impl.cc
Outdated
| @@ -194,7 +191,7 @@ OptionsImpl::OptionsImpl(int argc, const char* const* argv, | |||
| concurrency_ = std::max(1U, concurrency.getValue()); | |||
| config_path_ = config_path.getValue(); | |||
| config_yaml_ = config_yaml.getValue(); | |||
| v2_config_only_ = !allow_v1_config.getValue(); | |||
| v2_config_only_ = true; | |||
There was a problem hiding this comment.
You could probably kill this member variable now?
|
Changes LGTM. Should we kill v1 docs first? v1 docs appears everywhere and in higher place than v2 docs in most of search result... |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
| @@ -28,7 +29,7 @@ Version history | |||
| health check/weight/metadata updates within the given duration. | |||
| * config: regex validation added to limit to a maximum of 1024 characters. | |||
| * config: v1 disabled by default. v1 support remains available until October via flipping --v2-config-only=false. | |||
| * config: v1 disabled by default. v1 support remains available until October via setting :option:`--allow-deprecated-v1-api`. | |||
| * config: v1 disabled by default. v1 support remains available until October via deprecated flag --allow-deprecated-v1-api. | |||
There was a problem hiding this comment.
I don't think we should modify earlier release notes, this is a bit like rewriting history. Ideally once we release, they are immutable.
There was a problem hiding this comment.
Unfortunately I had to - the :option: tag was breaking the docs build now that the flag didn't exist.
I figured as long as I was removing the tagging I should explain why.
|
I'm inclined to make sure the v1 turndown sticks, but I'm happy to start the docs PR "in parallel" since digging out all the v1 references is probably going to take some time. |
| @@ -28,7 +29,7 @@ Version history | |||
| health check/weight/metadata updates within the given duration. | |||
| * config: regex validation added to limit to a maximum of 1024 characters. | |||
| * config: v1 disabled by default. v1 support remains available until October via flipping --v2-config-only=false. | |||
| * config: v1 disabled by default. v1 support remains available until October via setting :option:`--allow-deprecated-v1-api`. | |||
| * config: v1 disabled by default. v1 support remains available until October via deprecated flag --allow-deprecated-v1-api. | |||
I'm inclined to make the smallest possible change, removing the v1 enabling flag, and see if it sticks.
Risk Level: High
Testing: removed the v1 compat test
Docs Changes: not with this PR
Release Notes: Inline.
Part of #4617